Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement ChonkyBFT #211

Merged
merged 5 commits into from
Nov 5, 2024
Merged

feat: Implement ChonkyBFT #211

merged 5 commits into from
Nov 5, 2024

Conversation

brunoffranca
Copy link
Member

@brunoffranca brunoffranca commented Nov 1, 2024

Fixes BFT-452

Implemented all types for ChonkyBFT. Work on this is all on the roles
crate. Tests in roles crate are passing. Note that I'm not keeping the
old types, that's because `ReplicaCommit` has no changes to it (I
checked and serialization is the same for old and new, old signatures
still work) as well as `CommitQC` and `FinalBlock`. Any type that an EN
could receive, or that ends on our database, doesn't suffer any
alterations. So it seems that the upgrade to ChonkyBFT is
backwards-compatible for ENs. Since we only have one validator, we can
upgrade the whole network without a planned hard fork.

Part of BFT-452
- Everything in chonky_bft folder is basically new.
- UTHarness was moved to chonky_bft/testonly.rs. Several changes to it
though.
- All tests that use UTHarness were moved to chonky_bft/tests. Some of
the old unit tests were repurposed, but a fair amount of the tests in
chonky_bft/tests are new.
- The tests in tests.rs were split between tests/mod.rs and
tests/twins.rs (except for a few that used UTHarness and were moved as
said before). There were no changes to them though.

Part of BFT-452
@brunoffranca brunoffranca merged commit f4cc128 into main Nov 5, 2024
7 checks passed
@brunoffranca brunoffranca deleted the bf-chonky branch November 5, 2024 18:19
brunoffranca pushed a commit that referenced this pull request Nov 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2024-11-14)


### Features

* Implement ChonkyBFT
([#211](#211))
([f4cc128](f4cc128))


### Bug Fixes

* Add wrap around to table cells on Debug page
([#214](#214))
([6d52340](6d52340))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant